[Dashboard] Feature: Adds analytics to in-app-wallets page #5186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5186 +/- ##
=======================================
Coverage 45.36% 45.36%
=======================================
Files 1068 1068
Lines 55230 55230
Branches 3970 3970
=======================================
Hits 25055 25055
Misses 29483 29483
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
joaquim-verges
approved these changes
Oct 26, 2024
gregfromstl
force-pushed
the
feat/in-app-wallet-analytics
branch
from
202da19 to
a1d7d00
Compare
gregfromstl
force-pushed
the
feat/in-app-wallet-analytics
branch
from
a1d7d00 to
68ce340
Compare
Contributor
Merge activity
|
<img width="1106" alt="Screenshot 2024-10-25 at 4 02 59 PM" src="https://github.com/user-attachments/assets/8b559170-2d5e-4810-8a29-55f155448e40"> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the in-app wallets feature by adding tracking capabilities, restructuring components, and improving analytics. It introduces new interfaces, updates existing components, and removes unnecessary elements to streamline functionality and improve user experience. ### Detailed summary - Added `InAppWalletStats` interface. - Introduced `TRACKING_CATEGORY` constants for analytics. - Updated components to utilize new tracking categories. - Removed `AnalyticsCallout` from layout. - Replaced `Separator` with `<div className="h-5" />` for spacing. - Enhanced analytics pages to fetch and display wallet usage data. - Implemented new routing for in-app wallet analytics. - Updated `InAppWalletUsersChartCard` for better data visualization. - Improved the structure of the `Tabs` component for navigation. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
joaquim-verges
force-pushed
the
feat/in-app-wallet-analytics
branch
from
68ce340 to
2bf65c0
Compare
joaquim-verges
added a commit
that referenced
this pull request
Oct 28, 2024
joaquim-verges
pushed a commit
that referenced
this pull request
Oct 30, 2024
<img width="1106" alt="Screenshot 2024-10-25 at 4 02 59 PM" src="https://github.com/user-attachments/assets/8b559170-2d5e-4810-8a29-55f155448e40"> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the in-app wallets feature by adding tracking capabilities, restructuring components, and improving analytics. It introduces new interfaces, updates existing components, and removes unnecessary elements to streamline functionality and improve user experience. ### Detailed summary - Added `InAppWalletStats` interface. - Introduced `TRACKING_CATEGORY` constants for analytics. - Updated components to utilize new tracking categories. - Removed `AnalyticsCallout` from layout. - Replaced `Separator` with `<div className="h-5" />` for spacing. - Enhanced analytics pages to fetch and display wallet usage data. - Implemented new routing for in-app wallet analytics. - Updated `InAppWalletUsersChartCard` for better data visualization. - Improved the structure of the `Tabs` component for navigation. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
joaquim-verges
added a commit
that referenced
this pull request
Oct 30, 2024
…5227) Co-authored-by: gregfromstl <[email protected]>
joaquim-verges
added a commit
that referenced
this pull request
Oct 30, 2024
joaquim-verges
added a commit
that referenced
this pull request
Oct 30, 2024
joaquim-verges
added a commit
that referenced
this pull request
Oct 30, 2024
…5227) Co-authored-by: gregfromstl <[email protected]>
joaquim-verges
added a commit
that referenced
this pull request
Oct 30, 2024
…5227) Co-authored-by: gregfromstl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the in-app wallets feature by introducing new components, refining analytics, and improving the user interface. It also removes the
AnalyticsCalloutcomponent and updates tracking categories for better analytics management.Detailed summary
AnalyticsCalloutfrom the layout.InAppWalletStatsinterface.TRACKING_CATEGORYconstants for embedded wallets and team in-app wallets.Tabscomponents to accommodate new routes.